Skip to content

Conversation

@maximopalopoli
Copy link
Collaborator

@maximopalopoli maximopalopoli commented Jan 9, 2026

Description

This PR adds the bump fee option to the proof aggregator when the proof verification times out. This means that, in the event the proof aggregator attempts to submit the aggregated proof to the contract and the time elapsed is longer than a specified number of seconds, the proof aggregator will resubmit the proof by sending the same request with a higher fee to the network.

How to test

  1. Start ethereum package:
make ethereum_package_start
  1. Start gateway:
make agg_mode_gateway_start_ethereum_package
  1. Start payments poller:
make agg_mode_payments_poller_start_local
  1. Send payment and sp1 proof:
make agg_mode_gateway_send_payment
make agg_mode_gateway_send_sp1_proof
  1. Start proof aggregator with sp1:
make proof_aggregator_start AGGREGATOR=sp1

You can check that the normal flow works, or try to trigger some retries to check that the bump logic really works. I used this bump config at config-files/config-proof-aggregator.yaml:

# These values modify the bumping behavior after the aggregated proof on-chain submission times out.
max_bump_retries: 15
bump_retry_interval_seconds: 10
base_bump_percentage: 30
max_fee_bump_percentage: 100
priority_fee_gwei: 2

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change crates/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@maximopalopoli maximopalopoli self-assigned this Jan 9, 2026
@maximopalopoli maximopalopoli marked this pull request as ready for review January 12, 2026 17:54
Copy link
Collaborator

@JuArce JuArce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is missing handling the nonce for the transaction

@maximopalopoli maximopalopoli requested a review from JuArce January 13, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants